Remote Config realtime for Web #9199
Draft
+655
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
Samruddhi90
force-pushed
the
realtime-backoff
branch
from
3a792c1 to
7653692
Compare
Samruddhi90
force-pushed
the
realtime-backoff
branch
from
7653692 to
77a6aca
Compare
hsubox76
reviewed
Aug 11, 2025
| }; | ||
| } | ||
| const backoffEndTime = backoffMetadata.backoffEndTimeMillis.getTime(); | ||
| if (isBefore(new Date(), backoffEndTime)) { |
There was a problem hiding this comment.
It looks like this is the only place the date-fns dependency is used. Can we do this without date-fns? It doesn't seem worth bringing in a new dependency to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the logic for adding a new API, onConfigUpdate, for making a Realtime Connection and implementing backoff logic in case of errors. Making a connection and going into backoff is working as expected.
In follow-up PRs, we will add logic for handling tab visibility (foreground/background) to either make or close a connection based on activity, implement AutoFetch logic, and add unit tests.